git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7406: submodule.<name>.update command must not be run from .gitmodules

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 26, 2017, 06:28 UTC
Message-ID
<xmqqshfa9doa.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<0aa754b4-93fb-3f23-be51-4af5227ac847@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 13 quoted lines
>> +	test_when_finished "git -C super reset --hard HEAD^" &&
>> +
>> +	write_script must_not_run.sh <<-EOF &&
>> +	>$TEST_DIRECTORY/bad
>> +	EOF
>
> I am pretty confident that this does not test what you intend to
> test. Notice that $TEST_DIRECTORY is expanded when the script is
> written. But that path contains a blank, and we have something like
> this in the test script:
>
> 	#!/bin/sh
> 	>/the/build/directory/t/trash directory.t7406/bad
Nicely explained.  Thanks.
Previous: Johannes SixtNext: Stefan Beller
Message 6 of 10 in “t7406: submodule.<name>.update command must not be run from .gitmodules”
  1. t7406: submodule.<name>.update command must not be run from .gitmodulesStefan Beller, Sep 25, 2017
  2. Jonathan NiederSep 25, 2017
  3. t7406: submodule.<name>.update command must not be run from .gitmodulesStefan Beller, Sep 25, 2017
  4. Jonathan NiederSep 26, 2017
  5. Johannes SixtSep 26, 2017
  6. Junio C HamanoSep 26, 2017
  7. t7406: submodule.<name>.update command must not be run from .gitmodulesStefan Beller, Sep 26, 2017
  8. Johannes SixtSep 26, 2017
  9. t7406: submodule.<name>.update command must not be run from .gitmodulesStefan Beller, Sep 26, 2017
  10. Junio C HamanoSep 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.