From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 26 Sep 2017 06:28:21 GMT
Subject: Re: [PATCH] t7406: submodule.<name>.update command must not be run from .gitmodules
Message-ID: <xmqqshfa9doa.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <0aa754b4-93fb-3f23-be51-4af5227ac847@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

>> +	test_when_finished "git -C super reset --hard HEAD^" &&
>> +
>> +	write_script must_not_run.sh <<-EOF &&
>> +	>$TEST_DIRECTORY/bad
>> +	EOF
>
> I am pretty confident that this does not test what you intend to
> test. Notice that $TEST_DIRECTORY is expanded when the script is
> written. But that path contains a blank, and we have something like
> this in the test script:
>
> 	#!/bin/sh
> 	>/the/build/directory/t/trash directory.t7406/bad

Nicely explained.  Thanks.