Re: [PATCH 1/3] checkout.c: add strict usage of -- before file_path

From: Junio C Hamano <gitster@pobox.com>
Date: May 14, 2018, 01:51 UTC
Message-ID: <xmqqsh6vc8do.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8DZ1QvjO+JdbB76TOLtB2wp4Ya+CgsTyD1oz2Y+ZdKdYQ@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

>
> I would like an option to revert back to current behavior. I'm not a
> new user. I know what I'm doing. Please don't make me type more.

I can guarantee that nobody will stay a newbie. They either become more proficient and aware of what they are doing without having to think, at which point they start feeling the same way as you are. Or they leave the Git ecosystem and move to better things ;-)

> And '--" is not completely useless. If you have <file> and <branch>
> with the same name, you have to give "--" to to tell git what the
> first argument means.

Correct.

We _could_ do better than the corrent code, though, when we happen to have a file called 'master'. "git checkout master master" cannot mean anything other than "I want to make the index and the working tree copies of 'master' file to match what is recorded on the master branch", but I think we do require "git checkout master -- master" disambiguation.