Re: Re: [PATCH 1/3] checkout.c: add strict usage of -- before file_path

From: Dannier Castro L <danniercl@gmail.com>
Date: May 13, 2018, 19:11 UTC
Message-ID: <775fe020-be92-f65c-5a67-e83e6bf4777f@gmail.com>
In-Reply-To: <CACsJy8DZ1QvjO+JdbB76TOLtB2wp4Ya+CgsTyD1oz2Y+ZdKdYQ@mail.gmail.com>

On 13/05/2018 00:03, Duy Nguyen wrote:

Show 12 quoted lines

> On Sun, May 13, 2018 at 4:23 AM, Dannier Castro L <danniercl@gmail.com> wrote:
>> For GIT new users, this complicated versatility of <checkout> could
>> be very confused, also considering that actually the flag '--' is
>> completely useless (added or not, there is not any difference for
>> this command), when the same program messages promote the use of
>> this flag.
> I would like an option to revert back to current behavior. I'm not a
> new user. I know what I'm doing. Please don't make me type more.
>
> And '--" is not completely useless. If you have <file> and <branch>
> with the same name, you have to give "--" to to tell git what the
> first argument means.

Sure Duy, you're right, probably "completely useless" is not the correct definition, even according with the code I didn't find another useful case that is not file and branch with the same name. The program is able to know the type using only the name, turning "--" into an extra flag in most of cases.

I think this solution could please you more: By default the configuration is the current, but the user has the chance to set this, for example:

git config --global flag.strictdashdash true

Thank you so much for the spent time reviewing the patch, this is my first one in this repository.

-Dannier CL