Re: [PATCH 02/15] apply.c: stop using index compat macros

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2018, 18:30 UTC
Message-ID: <xmqqsh50qiiw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180630083825.GA2436@duynguyen.home>

Duy Nguyen <pclouds@gmail.com> writes:

> A singe patch conversion would look like below. But for that to
> happen, convert.c, rerere, ws.c and read-cache.c have to be converted
> first to not use the_index.

Yes, that was pretty much what I was driving at. I do not have any trouble seeing a patch that converts callees that are deep in the callchain and are meant to serve helpers to make them capable of working on arbitrary in-core index instance. That's a welcome change that allows us to reuse them in more context (namely, by callers that want to work on istate that is not the_index themselves). Skipping the "intermediate" step like this patch would force us to focus on converting these lower-layer dependencies.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.