From: Junio C Hamano Date: Tue, 03 Jul 2018 18:30:15 GMT Subject: Re: [PATCH 02/15] apply.c: stop using index compat macros Message-ID: In-Reply-To: <20180630083825.GA2436@duynguyen.home> Duy Nguyen writes: > A singe patch conversion would look like below. But for that to > happen, convert.c, rerere, ws.c and read-cache.c have to be converted > first to not use the_index. Yes, that was pretty much what I was driving at. I do not have any trouble seeing a patch that converts callees that are deep in the callchain and are meant to serve helpers to make them capable of working on arbitrary in-core index instance. That's a welcome change that allows us to reuse them in more context (namely, by callers that want to work on istate that is not the_index themselves). Skipping the "intermediate" step like this patch would force us to focus on converting these lower-layer dependencies.