git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] xdiff: use compat's MIN instead

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 22, 2018, 05:59 UTC
Message-ID
<xmqqsh0yv7wg.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181022053605.81048-4-carenas@gmail.com>
Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:
Show 8 quoted lines
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  xdiff/xdiffi.c     | 2 +-
>  xdiff/xemit.c      | 6 +++---
>  xdiff/xhistogram.c | 6 +++---
>  xdiff/xmacros.h    | 4 +---
>  xdiff/xprepare.c   | 2 +-
>  5 files changed, 9 insertions(+), 11 deletions(-)

As this is a borrowed code, I'd rather not do this, especially do so only for MIN so that people who update this need to be aware that they can say MIN() but still have to say XDL_MAX().

> -
> -#define XDL_MIN(a, b) ((a) < (b) ? (a): (b))
>  #define XDL_MAX(a, b) ((a) > (b) ? (a): (b))
Previous: Carlo Marcelo Arenas Belón
Message 8 of 8 in “refactor MIN macro”
  1. 0/3 refactor MIN macroCarlo Marcelo Arenas Belón, Oct 22, 2018
  2. 1/3 sha256: avoid redefinition for MINCarlo Marcelo Arenas Belón, Oct 22, 2018
  3. Junio C HamanoOct 22, 2018
  4. 2/3 git-compat-util: define MIN through compatCarlo Marcelo Arenas Belón, Oct 22, 2018
  5. Junio C HamanoOct 22, 2018
  6. Carlo ArenasOct 22, 2018
  7. 3/3 xdiff: use compat's MIN insteadCarlo Marcelo Arenas Belón, Oct 22, 2018
  8. Junio C HamanoOct 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.