git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] git-compat-util: define MIN through compat

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Oct 22, 2018, 05:36 UTC
Message-ID
<20181022053605.81048-3-carenas@gmail.com>
In-Reply-To
<20181022053605.81048-1-carenas@gmail.com>

this macro is commonly defined in system headers (usually <sys/param.h>) but if it is not define it here so it can be used elsewhere

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 git-compat-util.h     | 5 +++++
 sha256/block/sha256.c | 3 ---
 2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 5f2e90932f..7a0b48452b 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -218,6 +218,11 @@
 #else
 #include <stdint.h>
 #endif
+
+#ifndef MIN
+#define MIN(x, y) ((x) < (y) ? (x) : (y))
+#endif
+
 #ifdef NO_INTPTR_T
 /*
  * On I16LP32, ILP32 and LP64 "long" is the safe bet, however
diff --git a/sha256/block/sha256.c b/sha256/block/sha256.c
index 0d4939cc2c..5fba943c79 100644
--- a/sha256/block/sha256.c
+++ b/sha256/block/sha256.c
@@ -130,9 +130,6 @@ static void blk_SHA256_Transform(blk_SHA256_CTX *ctx, const unsigned char *buf)
 	}
 }
 
-#ifndef MIN
-#define MIN(x, y) ((x) < (y) ? (x) : (y))
-#endif
 void blk_SHA256_Update(blk_SHA256_CTX *ctx, const void *data, size_t len)
 {
 	const unsigned char *in = data;
-- 
2.19.1
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 8 in “refactor MIN macro”
  1. 0/3 refactor MIN macroCarlo Marcelo Arenas Belón, Oct 22, 2018
  2. 1/3 sha256: avoid redefinition for MINCarlo Marcelo Arenas Belón, Oct 22, 2018
  3. Junio C HamanoOct 22, 2018
  4. 2/3 git-compat-util: define MIN through compatCarlo Marcelo Arenas Belón, Oct 22, 2018
  5. Junio C HamanoOct 22, 2018
  6. Carlo ArenasOct 22, 2018
  7. 3/3 xdiff: use compat's MIN insteadCarlo Marcelo Arenas Belón, Oct 22, 2018
  8. Junio C HamanoOct 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.