Re: [PATCH 12/12] fsck: mark strings for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 29, 2018, 14:09 UTC
- Message-ID
- <xmqqsh0o3kuw.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20181029105304.GP30222@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 6 quoted lines
>> - fprintf(stderr, "%s in %s %s: %s\n",
>> - msg_type, printable_type(obj), describe_object(obj), err);
>> + fprintf_ln(stderr, _("%s in %s %s: %s"),
>
> Are the (f)printf() -> (f)printf_ln() changes all over
> 'builtin/fsck.c' really necessary to mark strings for translation?It is beyond absolute minimum but I saw it argued here that this makes it easier to manage the .po and .pot files if your message strings do not end with LF, a you are much less likely to _add_ unneeded LF to the translated string than _lose_ LF at the end of translated string.