Re: js/gcc-8-and-9, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2019, 14:28 UTC
Message-ID: <xmqqsgs5r6of.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1906181221360.44@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> What I *tried* to suggest is to take my minimal `kwset: allow building
> with GCC 8` together with the other three, as it fixes the build. Without
> it, the build is not fixed under `DEVELOPER=1`, it is still broken.

Ah, of course, we can do that.

Whether we are going to replace with newer LGPL2.1 copy (which I think is more conservative and tend to prefer) or removing it and require PCREv2 from everybody who does not want to see their fixed-grep performance degraded, we won't keep the "hack" when we take the one of these solutions for longer term, but it is a minimal and obvious workaround.