git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: pw/rebase-abort-clean-rewritten, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2019, 03:30 UTC
Message-ID
<xmqq7e9jsh8j.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<2a37d4c2-6eec-548d-0bd0-12bbd49c8071@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> Yes I sent it just before I went offline, but that's a while ago now

Yup. IIRC, you told us not to look at the patch "for now" as you would be offline, and I was fully expecting that a regular review exchange would happen after you come back.

I do not recall seeing much discussion, though, but ...
Show 5 quoted lines
>> Phillip, I was under the impression that all reviewer comments had been
>> resolved. Does that match your impression?
>
> Yes, I think it's ready. Thanks for prompting me dscho, I'd seen this
> was on hold and then forgotten to write to Junio

... if you resolved "all reviewer comments", it must have seen sufficient review, in which case let's merge it to 'next'.

Thanks.
Previous: Phillip WoodNext: Phillip Wood
Message 8 of 14 in “What's cooking in git.git (Jun 2019, #04; Fri, 14)”
  1. Junio C HamanoJun 14, 2019
  2. js/gcc-8-and-9, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)Johannes Schindelin, Jun 17, 2019
  3. Junio C HamanoJun 17, 2019
  4. Johannes SchindelinJun 18, 2019
  5. Junio C HamanoJun 19, 2019
  6. pw/rebase-abort-clean-rewritten, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)Johannes Schindelin, Jun 17, 2019
  7. Phillip WoodJun 17, 2019
  8. Junio C HamanoJun 18, 2019
  9. Phillip WoodJun 20, 2019
  10. Johannes SchindelinJun 21, 2019
  11. sg/rebase-progress, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14)Johannes Schindelin, Jun 17, 2019
  12. ds/commit-graph-incremental (was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14))Derrick Stolee, Jun 18, 2019
  13. Junio C HamanoJun 19, 2019
  14. Derrick StoleeJun 19, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.