Re: [PATCH 1/1] vreportf(): avoid buffered write in favor of unbuffered one

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

If it was buggy, the care given to it probably was insufficient, not overkill ;-)

As long as we know there won't be an overflow, and our compilers won't complain about possible overflow, simpler code that is easier to reason about is better. I tend to think that Peff's "consistently count based on offsets, instead of pointer arithmetic that you can easily get wrong" would give us an easier-to-read result in this case.

Thanks for simplifying the original "overkill" version. Except for the bug resulting from misunderstanding of strlcpy() return value, the version I saw was a quite pleasant read.