Re: [PATCH 0/9] [RFC] Changed Paths Bloom Filters

From

Junio C Hamano <gitster@pobox.com>

Date

Dec 30, 2019, 17:02 UTC

Message-ID

<xmqqsgl1hhlw.fsf@gitster-ct.c.googlers.com>

In-Reply-To

<20191229062414.GC220034@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> This is holding internal state in diff_options, but the same
> diff_options is often used for multiple diffs (e.g., "git log --raw"
> would use the same rev_info.diffopt over and over again).
>
> So it would need to be cleared between diffs. There's a similar feature
> in the "has_changes" flag, though it looks like it is cleared manually
> by callers. Yuck.

> I actually wonder if this could be rolled into the has_changes and
> diff_can_quit_early() feature. This really just a generalization of that
> feature (which is like setting max_changes to "1").