Re: [PATCH 2/9] commit-graph: write changed paths bloom filters

From: Philip Oakley <philipoakley@iee.email>
Date: Dec 21, 2019, 16:48 UTC
Message-ID: <39ef6bc6-4f21-1ba6-ad6e-06cb1a2423ac@iee.email>
In-Reply-To: <e52c7ad37a306891487bd79a09b040bfb657d723.1576879520.git.gitgitgadget@gmail.com>

spelling nit?

On 20/12/2019 22:05, Garima Singh via GitGitGadget wrote:

Show 6 quoted lines

> 1. The implementation sticks to the recommended values of 7 and 10 for the
>    number of hashes and the size of each entry, as described in the blog.
>    The implementation while not completely open to it at the moment, is flexible
>    enough to allow for tweaking these settings in the future.
>    Note: The performance gains we have observed so far with these values is
>    significant enough to not that we did not need to tweak these settings.

s/not/note/ (first occurrence)

>    The cover letter of this series has the details and the commit where we have
>    git log use bloom filters.

Philip