git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] t5509: initialized `pushee` as bare repository

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 13, 2020, 20:14 UTC
Message-ID
<xmqqsgjeqm6w.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<d156d04ca87f9fcffb1c08a08576dddcdc64c055.1581620351.git.gitgitgadget@gmail.com>
"Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 5 quoted lines
> From: Hariom Verma <hariom18599@gmail.com>
>
> `receive.denyCurrentBranch` currently has a bug where it allows pushing
> into the current branch of a non-bare repository as long as it does not
> have any commits.

Can patch 3/3 be split into two, so that the fix would protect an already populated branch that is checked out anywhere (not in the primary worktree--which is the bug you are fixing) from getting updated but still allow an unborn branch to be updated, and then have patch 4/3 that forbids an update to even an unborn branch "checked out" in any working tree? This update to the test can then become part of patch 4/3.

Thanks.
Previous: Hariom Verma via GitGitGadgetNext: Junio C Hamano
Message 3 of 30 in “[GSoC] receive.denyCurrentBranch: respect all worktrees”
  1. 0/3 [GSoC] receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 13, 2020
  2. 2/3 t5509: initialized `pushee` as bare repositoryHariom Verma via GitGitGadget, Feb 13, 2020
  3. Junio C HamanoFeb 13, 2020
  4. Junio C HamanoFeb 13, 2020
  5. Johannes SchindelinFeb 14, 2020
  6. Junio C HamanoFeb 14, 2020
  7. Hariom vermaFeb 15, 2020
  8. Junio C HamanoFeb 16, 2020
  9. Hariom vermaFeb 22, 2020
  10. 1/3 get_main_worktree(): allow it to be called in the Git directoryHariom Verma via GitGitGadget, Feb 13, 2020
  11. 3/3 receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 13, 2020
  12. 0/4 [GSoC] receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 22, 2020
  13. 2/4 t5509: initialized `pushee` as bare repositoryHariom Verma via GitGitGadget, Feb 22, 2020
  14. Junio C HamanoFeb 23, 2020
  15. 3/4 bug: denyCurrentBranch and unborn branch with ref namespaceHariom Verma via GitGitGadget, Feb 22, 2020
  16. Junio C HamanoFeb 23, 2020
  17. 1/4 get_main_worktree(): allow it to be called in the Git directoryHariom Verma via GitGitGadget, Feb 22, 2020
  18. 4/4 receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 22, 2020
  19. Junio C HamanoFeb 23, 2020
  20. 0/3 [GSoC] receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 23, 2020
  21. 1/3 get_main_worktree(): allow it to be called in the Git directoryHariom Verma via GitGitGadget, Feb 23, 2020
  22. Eric SunshineFeb 24, 2020
  23. Hariom vermaFeb 24, 2020
  24. Eric SunshineFeb 24, 2020
  25. Johannes SchindelinFeb 24, 2020
  26. Eric SunshineFeb 24, 2020
  27. Johannes SchindelinFeb 27, 2020
  28. Junio C HamanoFeb 24, 2020
  29. 2/3 t5509: use a bare repository for test push targetHariom Verma via GitGitGadget, Feb 23, 2020
  30. 3/3 receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.