git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] [GSoC] receive.denyCurrentBranch: respect all worktrees

From
HGHariom Verma via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 13, 2020, 18:59 UTC
Message-ID
<pull.535.git.1581620351.gitgitgadget@gmail.com>

The receive.denyCurrentBranch config option controls what happens if you push to a branch that is checkout into a non-bare repository. By default, it rejects it. It can be disabled via ignore or warn. Another yet trickier option is updateInstead.

When receive.denyCurrentBranch is set to updateInstead, a push that tries to update the branch that is currently checked out is accepted only when the index and the working tree exactly matches the currently checked out commit, in which case the index and the working tree are updated to match the pushed commit. Otherwise, the push is refused.

However, this setting was forgotten when the git worktree command was introduced: only the main worktree's current branch is respected. [ fixes: #331 ]

Incidently, this change also fixes another bug i.e. receive.denyCurrentBranch = true was ignored when pushing into a non-bare repository's unborn current branch.

Thanks, @dscho for helping me out.
Regards, Hariom
Hariom Verma (3):
  get_main_worktree(): allow it to be called in the Git directory
  t5509: initialized `pushee` as bare repository
  receive.denyCurrentBranch: respect all worktrees
 builtin/receive-pack.c           | 37 +++++++++++++++++---------------
 t/t5509-fetch-push-namespaces.sh |  2 +-
 t/t5516-fetch-push.sh            | 11 ++++++++++
 worktree.c                       |  1 +
 4 files changed, 33 insertions(+), 18 deletions(-)
base-commit: 232378479ee6c66206d47a9be175e3a39682aea6
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-535%2Fharry-hov%2Fdeny-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-535/harry-hov/deny-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/535
-- 
gitgitgadget
Next: Hariom Verma via GitGitGadget
Message 1 of 30 in “[GSoC] receive.denyCurrentBranch: respect all worktrees”
  1. 0/3 [GSoC] receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 13, 2020
  2. 2/3 t5509: initialized `pushee` as bare repositoryHariom Verma via GitGitGadget, Feb 13, 2020
  3. Junio C HamanoFeb 13, 2020
  4. Junio C HamanoFeb 13, 2020
  5. Johannes SchindelinFeb 14, 2020
  6. Junio C HamanoFeb 14, 2020
  7. Hariom vermaFeb 15, 2020
  8. Junio C HamanoFeb 16, 2020
  9. Hariom vermaFeb 22, 2020
  10. 1/3 get_main_worktree(): allow it to be called in the Git directoryHariom Verma via GitGitGadget, Feb 13, 2020
  11. 3/3 receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 13, 2020
  12. 0/4 [GSoC] receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 22, 2020
  13. 2/4 t5509: initialized `pushee` as bare repositoryHariom Verma via GitGitGadget, Feb 22, 2020
  14. Junio C HamanoFeb 23, 2020
  15. 3/4 bug: denyCurrentBranch and unborn branch with ref namespaceHariom Verma via GitGitGadget, Feb 22, 2020
  16. Junio C HamanoFeb 23, 2020
  17. 1/4 get_main_worktree(): allow it to be called in the Git directoryHariom Verma via GitGitGadget, Feb 22, 2020
  18. 4/4 receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 22, 2020
  19. Junio C HamanoFeb 23, 2020
  20. 0/3 [GSoC] receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 23, 2020
  21. 1/3 get_main_worktree(): allow it to be called in the Git directoryHariom Verma via GitGitGadget, Feb 23, 2020
  22. Eric SunshineFeb 24, 2020
  23. Hariom vermaFeb 24, 2020
  24. Eric SunshineFeb 24, 2020
  25. Johannes SchindelinFeb 24, 2020
  26. Eric SunshineFeb 24, 2020
  27. Johannes SchindelinFeb 27, 2020
  28. Junio C HamanoFeb 24, 2020
  29. 2/3 t5509: use a bare repository for test push targetHariom Verma via GitGitGadget, Feb 23, 2020
  30. 3/3 receive.denyCurrentBranch: respect all worktreesHariom Verma via GitGitGadget, Feb 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.