Re: jc/sequencer-stopped-sha-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2020, 18:34 UTC
Message-ID: <xmqqsg9rvc9z.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2011020237070.18437@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 22 quoted lines

> Hi Junio,
>
> On Tue, 27 Oct 2020, Junio C Hamano wrote:
>
>> * jc/sequencer-stopped-sha-simplify (2020-10-21) 1 commit
>>  - sequencer: tolerate abbreviated stopped-sha file
>>
>>  Recently the format of an internal state file "rebase -i" uses has
>>  been tightened up for consistency, which would hurt those who start
>>  "rebase -i" with old git and then continue with new git.  Loosen
>>  the reader side a bit (which we may want to tighten again in a year
>>  or so).
>>
>>  Is this a real issue, or just a theoretical one?
>>  cf. <xmqqd01b429a.fsf@gitster.c.googlers.com>
>
> We had a similar situation when we decided to fix the incorrect quoting in
> the `author-script` file, and we decided that we have to be careful:
> https://lore.kernel.org/git/nycvar.QRO.7.76.6.1807271415410.10478@tvgsbejvaqbjf.bet/
>
> In light of that, I think we should go with Jonathan's patch for a couple
> of versions before tightening the reader side again.

I do not mind taking the approach as a prudent and careful thing, but I want the question answered regardless, as I know Jonathan is in a good position to tell if this is just a theoretical issue than I am, and depending on the answer, we may rethink the approach of trying to be overly careful.

Thanks.