git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: jc/sequencer-stopped-sha-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Nov 2, 2020, 18:46 UTC
Message-ID
<20201102184634.3280859-1-jonathantanmy@google.com>
In-Reply-To
<xmqqsg9rvc9z.fsf@gitster.c.googlers.com>
Show 30 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Hi Junio,
> >
> > On Tue, 27 Oct 2020, Junio C Hamano wrote:
> >
> >> * jc/sequencer-stopped-sha-simplify (2020-10-21) 1 commit
> >>  - sequencer: tolerate abbreviated stopped-sha file
> >>
> >>  Recently the format of an internal state file "rebase -i" uses has
> >>  been tightened up for consistency, which would hurt those who start
> >>  "rebase -i" with old git and then continue with new git.  Loosen
> >>  the reader side a bit (which we may want to tighten again in a year
> >>  or so).
> >>
> >>  Is this a real issue, or just a theoretical one?
> >>  cf. <xmqqd01b429a.fsf@gitster.c.googlers.com>
> >
> > We had a similar situation when we decided to fix the incorrect quoting in
> > the `author-script` file, and we decided that we have to be careful:
> > https://lore.kernel.org/git/nycvar.QRO.7.76.6.1807271415410.10478@tvgsbejvaqbjf.bet/
> >
> > In light of that, I think we should go with Jonathan's patch for a couple
> > of versions before tightening the reader side again.
> 
> I do not mind taking the approach as a prudent and careful thing,
> but I want the question answered regardless, as I know Jonathan is
> in a good position to tell if this is just a theoretical issue than
> I am, and depending on the answer, we may rethink the approach of
> trying to be overly careful.

From what I see, this is just a theoretical issue for now. (I spotted it while looking at the code, not because of a bug report.)

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 14 in “What's cooking in git.git (Oct 2020, #04; Tue, 27)”
  1. Junio C HamanoOct 27, 2020
  2. jc/sequencer-stopped-sha-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)Johannes Schindelin, Nov 2, 2020
  3. Junio C HamanoNov 2, 2020
  4. Jonathan TanNov 2, 2020
  5. Junio C HamanoNov 2, 2020
  6. jk/committer-date-is-author-date-fix-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)Johannes Schindelin, Nov 2, 2020
  7. Junio C HamanoNov 2, 2020
  8. sj/untracked-files-in-submodule-directory-is-not-dirty, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)Johannes Schindelin, Nov 2, 2020
  9. Junio C HamanoNov 3, 2020
  10. ag/merge-strategies-in-c, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)Johannes Schindelin, Nov 2, 2020
  11. Junio C HamanoNov 2, 2020
  12. Alban GruinNov 2, 2020
  13. Junio C HamanoNov 3, 2020
  14. Johannes SchindelinNov 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.