git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitignore: remove entry for git serve

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 2, 2020, 22:32 UTC
Message-ID
<xmqqsg8nltzx.fsf@gitster.c.googlers.com>
In-Reply-To
<X8eNGzay6yWSEoJH@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote:
>
>> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git
>> serve from a builtin command to a test helper.  As a result the
>> git-serve binary is no longer built and thus doesn't have to be ignored
>> anymore.
>
> Good catch. This shows a weakness in my detection script: I had a stale
> git-serve sitting around from building old versions of Git. :)
>
> I repeated the script in a "clean" directory that was a fresh clone +
> make, and diffed the results. git-serve was the only interesting
> difference I saw. So this is probably the last of the low-hanging fruit.
Thanks, all.  

Just for simplicity, these two are also queued on the same "random cleanup" topic branch started with Felipe's four trivial clean-up patches.

Previous: Jeff King
Message 18 of 18 in “Random cleanups”
  1. 0/4 Random cleanupsFelipe Contreras, Dec 1, 2020
  2. 4/4 tests: lib-functions: trivial style cleanupsFelipe Contreras, Dec 1, 2020
  3. 1/4 refspec: trivial cleanupFelipe Contreras, Dec 1, 2020
  4. Jeff KingDec 1, 2020
  5. Junio C HamanoDec 1, 2020
  6. Felipe ContrerasDec 1, 2020
  7. Jeff KingDec 2, 2020
  8. Felipe ContrerasDec 2, 2020
  9. 3/4 test: completion: fix typosFelipe Contreras, Dec 1, 2020
  10. 2/4 .gitignore: remove dangling fileFelipe Contreras, Dec 1, 2020
  11. Junio C HamanoDec 1, 2020
  12. Felipe ContrerasDec 1, 2020
  13. Jeff KingDec 2, 2020
  14. Felipe ContrerasDec 2, 2020
  15. gitignore: remove entry for git serveRené Scharfe, Dec 2, 2020
  16. Johannes SchindelinDec 2, 2020
  17. Jeff KingDec 2, 2020
  18. Junio C HamanoDec 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.