Re: [PATCH] gitignore: remove entry for git serve
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 2, 2020, 22:32 UTC
- Message-ID
- <xmqqsg8nltzx.fsf@gitster.c.googlers.com>
- In-Reply-To
- <X8eNGzay6yWSEoJH@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote: > >> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git >> serve from a builtin command to a test helper. As a result the >> git-serve binary is no longer built and thus doesn't have to be ignored >> anymore. > > Good catch. This shows a weakness in my detection script: I had a stale > git-serve sitting around from building old versions of Git. :) > > I repeated the script in a "clean" directory that was a fresh clone + > make, and diffed the results. git-serve was the only interesting > difference I saw. So this is probably the last of the low-hanging fruit.
Thanks, all.
Just for simplicity, these two are also queued on the same "random cleanup" topic branch started with Felipe's four trivial clean-up patches.