git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] refspec: trivial cleanup

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Dec 1, 2020, 00:46 UTC
Message-ID
<20201201004649.57548-2-felipe.contreras@gmail.com>
In-Reply-To
<20201201004649.57548-1-felipe.contreras@gmail.com>

We can remove one level of indentation and make the code clearer. So why not do so?

No functional changes.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 refspec.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/refspec.c b/refspec.c
index c49347c2d7..d4823dbff9 100644
--- a/refspec.c
+++ b/refspec.c
@@ -272,15 +272,16 @@ void refspec_ref_prefixes(const struct refspec *rs,
 		else if (item->src && !item->exact_sha1)
 			prefix = item->src;
 
-		if (prefix) {
-			if (item->pattern) {
-				const char *glob = strchr(prefix, '*');
-				strvec_pushf(ref_prefixes, "%.*s",
-					     (int)(glob - prefix),
-					     prefix);
-			} else {
-				expand_ref_prefix(ref_prefixes, prefix);
-			}
+		if (!prefix)
+			continue;
+
+		if (item->pattern) {
+			const char *glob = strchr(prefix, '*');
+			strvec_pushf(ref_prefixes, "%.*s",
+				     (int)(glob - prefix),
+				     prefix);
+		} else {
+			expand_ref_prefix(ref_prefixes, prefix);
 		}
 	}
 }
-- 
2.29.2
Previous: Felipe ContrerasNext: Jeff King
Message 3 of 18 in “Random cleanups”
  1. 0/4 Random cleanupsFelipe Contreras, Dec 1, 2020
  2. 4/4 tests: lib-functions: trivial style cleanupsFelipe Contreras, Dec 1, 2020
  3. 1/4 refspec: trivial cleanupFelipe Contreras, Dec 1, 2020
  4. Jeff KingDec 1, 2020
  5. Junio C HamanoDec 1, 2020
  6. Felipe ContrerasDec 1, 2020
  7. Jeff KingDec 2, 2020
  8. Felipe ContrerasDec 2, 2020
  9. 3/4 test: completion: fix typosFelipe Contreras, Dec 1, 2020
  10. 2/4 .gitignore: remove dangling fileFelipe Contreras, Dec 1, 2020
  11. Junio C HamanoDec 1, 2020
  12. Felipe ContrerasDec 1, 2020
  13. Jeff KingDec 2, 2020
  14. Felipe ContrerasDec 2, 2020
  15. gitignore: remove entry for git serveRené Scharfe, Dec 2, 2020
  16. Johannes SchindelinDec 2, 2020
  17. Jeff KingDec 2, 2020
  18. Junio C HamanoDec 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.