Re: [PATCH v2 3/6] ssh signing: make verify-commit consider key lifetime

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2021, 20:30 UTC
Message-ID: <xmqqsfwmus5g.fsf@gitster.g>
In-Reply-To: <20211027080616.619956-4-fs@gigacodes.de>

Fabian Stelzer <fs@gigacodes.de> writes:

Show 18 quoted lines

> +static int parse_payload_metadata(struct signature_check *sigc)
> +{
> +	const char *ident_line = NULL;
> +	size_t ident_len;
> +	struct ident_split ident;
> +	const char *signer_header;
> +
> +	switch(sigc->payload_type) {
> +		case SIGNATURE_PAYLOAD_COMMIT:
> +			signer_header = "committer";
> +			break;
> +		case SIGNATURE_PAYLOAD_TAG:
> +			signer_header = "tagger";
> +			break;
> +		default:
> +			/* Ignore unknown payload types */
> +			return 0;
> +	}

The case arms should be indented to the same level as opening switch(). Have SP between keyword "switch" and the expression the statement switches on.

More importantly, can you explain why it is necessary to allow callers to call this function with a random value in payload_type and have it silently succeed? Isn't it a programming error that deserves a call to BUG("...")?

Thanks.