Re: [PATCH v5 8/8] t/fmt-merge-msg: make gpg/ssh tests more specific

>Fabian Stelzer <fs@gigacodes.de> writes:
>
>> All the GPG, GPGSSH and the new GPGSSH_VERIFYTIME tests are redirecing
>> stdout as well as stderr to `actual` and grep for success/failure over
>> the resulting flie. However, no output is printed on stderr and we do
>> not need to include it in the grep. The newer SSH signing based tests
>> are also missing a grep for the merged tag to make sure the merge
>> message is correct.
>>
>> - remove unneccessary 2>&1 redirects
>> - add grep for merged tag to gpgssh* tests
>>
>> Signed-off-by: Fabian Stelzer <fs@gigacodes.de>
>> ---
>>  t/t6200-fmt-merge-msg.sh | 21 +++++++++++++--------
>>  1 file changed, 13 insertions(+), 8 deletions(-)
>
>The 4 hunks at the beginning seems to be a clean-up of the existing
>issue, but aren't hunks -162,7, -170,7, -178,7, 187,7 "oops, we
>screwed up in [6/8], and we patch up after the fact"?
>
>For a new topic not yet in 'next', we'd prefer to pretend to be more
>perfect humans by not deliberatly keeping mistakes made in an
>earlier step, only to be corrected in a later step.
>
>While there may not be any difference in the end-result, it would be
>cleaner and less sloppy to have the 4 hunks to fix the ones before
>the series as a preliminary clean-up step, and the other hunks
>folded into the step that introduced the problem, no?
>