Re: [PATCH v2 1/6] test-ref-store: plug memory leak in cmd_delete_refs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 29, 2021, 23:15 UTC
- Message-ID
- <xmqqsfve4kqj.fsf@gitster.g>
- In-Reply-To
- <7fa5c247c8b1cdeb4fcd166cfb6e98425d21e5ae.1638211786.git.gitgitgadget@gmail.com>
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 17 quoted lines
> From: Han-Wen Nienhuys <hanwen@google.com> > > Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> > --- > t/helper/test-ref-store.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c > index b314b81a45b..ccc2bb01bf3 100644 > --- a/t/helper/test-ref-store.c > +++ b/t/helper/test-ref-store.c > @@ -86,11 +86,13 @@ static int cmd_delete_refs(struct ref_store *refs, const char **argv) > unsigned int flags = arg_flags(*argv++, "flags"); > const char *msg = *argv++; > struct string_list refnames = STRING_LIST_INIT_NODUP; > - > + int result;
Thanks, but let's not lose the blank line between the declarations and the first statement, which serves for readability.
Show 10 quoted lines
> while (*argv) > string_list_append(&refnames, *argv++); > > - return refs_delete_refs(refs, msg, &refnames, flags); > + result = refs_delete_refs(refs, msg, &refnames, flags); > + string_list_clear(&refnames, 0); > + return result; > } > > static int cmd_rename_ref(struct ref_store *refs, const char **argv)