Re: [PATCH v2 4/6] refs: add REF_SKIP_REFNAME_VERIFICATION flag
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Nov 30, 2021, 10:31 UTC
- Message-ID
- <CAFQ2z_M35tbF6+C2MkMRm7hO8CNdUSrGTcx+8Os348+rHu4ojg@mail.gmail.com>
- In-Reply-To
- <xmqqbl224k09.fsf@gitster.g>
On Tue, Nov 30, 2021 at 12:31 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> > + if (!(flags & REF_SKIP_REFNAME_VERIFICATION) &&
> > + ((new_oid && !is_null_oid(new_oid)) ?
> > + check_refname_format(refname, REFNAME_ALLOW_ONELEVEL) :
> > + !refname_is_safe(refname))) {
>
> So, if somebody passes REF_SKIP_REFNAME_VERIFICATION in flags, we
> will not do the check.
>
> Again, like 3/6, this new bit is flipped on by test-helper
> somewhere? Again I do not see anybody doing so in these 6 patches,
> but I should double check.The test helper takes the flag as an argument, in decimal. If you look for 2048, you should find it.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado