Re: Bug report - sparse-checkout ignores prefix when run in subdirectories

From

Junio C Hamano <gitster@pobox.com>

Date

Jan 5, 2022, 22:38 UTC

Message-ID

<xmqqsfu1g64s.fsf@gitster.g>

In-Reply-To

<29f0410e-6dfa-2e86-394d-b1fb735e7608@gmail.com>

Lessley Dennington <lessleydennington@gmail.com> writes:

> Hello everyone! See the following bug report pertaining to sparse-checkout
> when run outside top-level directories.

Perhaps something along this line?

 builtin/sparse-checkout.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git c/builtin/sparse-checkout.c w/builtin/sparse-checkout.c
index 45e838d8f8..4e5efbb85e 100644
--- c/builtin/sparse-checkout.c
+++ w/builtin/sparse-checkout.c
@@ -753,6 +753,16 @@ static int sparse_checkout_set(int argc, const char **argv, const char *prefix)
 	if (!core_sparse_checkout_cone && argc == 0) {
 		argv = default_patterns;
 		argc = default_patterns_nr;
+	} else if (argc && prefix && *prefix) {
+		/* 
+		 * The args are not pathspecs, so unfortunately we
+		 * cannot imitate how cmd_add() uses parse_pathspec().
+		 */
+		int i;
+		int prefix_len = strlen(prefix);
+
+		for (i = 0; i < argc; i++)
+			argv[i] = prefix_path(prefix, prefix_len, argv[i]);
 	}
 
 	return modify_pattern_list(argc, argv, set_opts.use_stdin, REPLACE);