Re: Bug report - sparse-checkout ignores prefix when run in subdirectories

From: Elijah Newren <newren@gmail.com>
Date: Jan 6, 2022, 01:08 UTC
Message-ID: <CABPp-BF=-1aZd=nFHF6spo7Ksa7f7Wb7ervCt0QvtNitMY=ZBA@mail.gmail.com>
In-Reply-To: <xmqq7dbdg1k6.fsf@gitster.g>

On Wed, Jan 5, 2022 at 4:17 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

>
> Elijah Newren <newren@gmail.com> writes:
>
> > Are you possibly confusing pathspecs with gitignore patterns here?
> > (Or am I?)  Or are you suggesting that sparse-checkout be modified to
> > accept either gitignore-style files or pathspecs and handle both?
>
> Much closer to the latter (actually, removing ignore patterns, and
> make the subsystem work with pathspecs).

Oh, interesting. That'd at least suggest you're also happy to get rid of the ignore patterns in this subsystem if we find a feasible transition plan to do so. I'll keep that in mind. :-)

Show 10 quoted lines

> > I have never liked that gitignore-style patterns were used for
> > sparse-checkout, but it has always seemed a bit too late to change it.
>
> Perhaps.
>
> > Ever since Stolee introduced cone-mode, my preferred strategy for
> > fixing the gitignore-style patterns problem, assuming we are allowed
> > to do so, is to deprecate if not kill non-cone mode.  (And in the
> > meantime, I'm just doing due diligence when I mention non-cone mode in
> > my reviews.)