git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t0301-credential-cache test failure on cygwin

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2022, 18:26 UTC
Message-ID
<xmqqsfnczslt.fsf@gitster.g>
In-Reply-To
<YsciDznU2TqzCXP4@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> Of the three, I actually like the client-side one to check errno the
> best. The client is mostly "best effort". If it can't talk to the daemon
> for whatever reason, then it becomes a noop (there is nothing it can
> retrieve from the cache, and if it's trying to write, then oh well, the
> cached value was immediately expired!).
>
> So one could argue that _every_ read error should be silently ignored.
> Calling die_errno() is mostly a nicety for debugging a broken setup, but
> in normal use, the outcome is the same either way (and Git will
> certainly ignore the exit code credential-cache anyway). I prefer the
> "ignore known harmless errors" approach, possibly because I am often the
> one debugging. ;) If ECONNABORTED is a harmless error we see in
> practice, I don't mind adding it to the list (under the same rationale
> as the current ECONNRESET that is there).

With the issue of race clearly explained, I agree that this would be the best solution for this issue.

Thanks.
Previous: Jeff KingNext: Ramsay Jones
Message 14 of 15 in “t0301-credential-cache test failure on cygwin”
  1. Ramsay JonesJul 7, 2022
  2. Junio C HamanoJul 7, 2022
  3. Ramsay JonesJul 7, 2022
  4. Jeff KingJul 7, 2022
  5. Jeff KingJul 7, 2022
  6. Ramsay JonesJul 7, 2022
  7. Adam DinwoodieJul 11, 2022
  8. Adam DinwoodieJul 11, 2022
  9. Ramsay JonesJul 11, 2022
  10. Adam DinwoodieJul 13, 2022
  11. Jeff KingJul 13, 2022
  12. Ramsay JonesJul 13, 2022
  13. Jeff KingJul 7, 2022
  14. Junio C HamanoJul 7, 2022
  15. Ramsay JonesJul 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.