git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t0301-credential-cache test failure on cygwin

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jul 7, 2022, 19:14 UTC
Message-ID
<fa951e27-7b7b-848c-01c8-f706f97d87e7@ramsayjones.plus.com>
In-Reply-To
<Yscl/Jx4g74RwkCK@coredump.intra.peff.net>
On 07/07/2022 19:29, Jeff King wrote:
Show 13 quoted lines
> On Thu, Jul 07, 2022 at 04:17:08PM +0100, Ramsay Jones wrote:
> 
>> Also, I would like to understand why the code is written as it is
>> currently. I'm sure there must be a good reason - I just don't know
>> what it is! I suspect (ie I'm guessing), it has something to do with
>> operating in a high contention context [TOCTOU on socket?] ... dunno. ;-)
> 
> By the way, I was slightly surprised you did not find the explanation in
> the commit history. A blame[1] of credential-cache--daemon.c shows that
> the comment was added by 7d5e9c9849 (credential-cache--daemon: clarify
> "exit" action semantics, 2016-03-18) which mentions the race in the
> tests. And then searching for that commit message in the list yields the
> thread I linked earlier with more context[2].

Heh, just 10min before I read your previous email (er, actually your previous, previous email) I found commit 7d5e9c9849 (credential-cache--daemon: clarify "exit" action semantics, 2016-03-18). I hadn't had time to dig any further yet (as usual I'm trying to do 3 things at the same time).

What can I say? It was nearly 3am and I wanted to go bed. It took nearly 50min just to write the email. This was just a _quick_ look remember! ;-)

Sorry!

ATB, Ramsay Jones

Previous: Jeff KingNext: Adam Dinwoodie
Message 6 of 15 in “t0301-credential-cache test failure on cygwin”
  1. Ramsay JonesJul 7, 2022
  2. Junio C HamanoJul 7, 2022
  3. Ramsay JonesJul 7, 2022
  4. Jeff KingJul 7, 2022
  5. Jeff KingJul 7, 2022
  6. Ramsay JonesJul 7, 2022
  7. Adam DinwoodieJul 11, 2022
  8. Adam DinwoodieJul 11, 2022
  9. Ramsay JonesJul 11, 2022
  10. Adam DinwoodieJul 13, 2022
  11. Jeff KingJul 13, 2022
  12. Ramsay JonesJul 13, 2022
  13. Jeff KingJul 7, 2022
  14. Junio C HamanoJul 7, 2022
  15. Ramsay JonesJul 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.