Re: [PATCH v0 0/4] Remove obsolete Cygwin support from git-gui

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 26, 2023, 15:52 UTC
Message-ID: <xmqqsfae5igi.fsf@gitster.g>
In-Reply-To: <b7181a2d-ba97-eae8-6bf4-4fc4b0db64c2@gmail.com>

Mark Levedahl <mlevedahl@gmail.com> writes:

Show 9 quoted lines

> I had originally organized as you suggest, no problem doing so
> again. What gave me pause was this paragraph I originally wrote for
> the cover letter:
>
> Patches 1/2 cause git-gui to function as it has for the last decade on
> Cygwin, but with Cygwin being detected. However, the browsing and
> shortcut creation menu items, removed in 2012 then re-added when is_Cygwin
> was fixed, do not work, and shortcut creation will crash git-gui if used.
> These are fixed in patches 3 / 4.

As you are removing (ancient) Cygwin specific code that did not work with modern Cygwin at all in step [2/4], it is not so unexpected that some stuff does still not work after that step. I am not sure what your reservation exactly is, but if you are wondering if code to disable browsing and shortcut creation on Cygwin temporarily needs to be there in the same step (instead of crashing or not working), it may make sense if and only if it is done with minimal changes.

Thanks.