Re: [PATCH v1 0/4] Remove obsolete Cygwin support from git-gui
- From
Mark Levedahl <mlevedahl@gmail.com>
- Date
- Aug 5, 2023, 14:47 UTC
- Message-ID
- <07677f17-be9b-dc46-d204-6fe46d46ebc0@gmail.com>
- In-Reply-To
- <xmqq4jmsiyhw.fsf@gitster.g>
On 6/27/23 13:52, Junio C Hamano wrote:
Show 31 quoted lines
> Mark Levedahl <mlevedahl@gmail.com> writes: > >> === This is an update, incorporating responses to Junio's and Eric's >> comments: >> -- clarified what the "upstream" git-gui branch is >> -- Removed some changes from patch 2 as requested by Junio, reducing >> changes in patch 3 and patch 4 >> All code is fixed only after applying patch 4 >> Differences in patch 3 and 4 are minimimized >> -- updated comments to clarify G4w dedicated code. >> -- updated all comments to (hopefully) clarify points of confusion >> === >> ... >> Mark Levedahl (4): >> git gui Makefile - remove Cygwin modifications >> git-gui - remove obsolete Cygwin specific code >> git-gui - use cygstart to browse on Cygwin >> git-gui - use mkshortcut on Cygwin >> >> Makefile | 21 +------ >> git-gui.sh | 118 +++----------------------------------- >> lib/choose_repository.tcl | 27 +-------- >> lib/shortcut.tcl | 31 +++++----- >> 4 files changed, 27 insertions(+), 170 deletions(-) > OK, Dscho says v1 looks good, and I have no further comments. > > Pratyush, can I expect that you take further comments and usher > these patches to your tree, and eventually tell me to pull from your > repository? > > Thanks, all.
Junio,
Thank you and Dscho for the detailed reviews. But, there is no response from Pratyush in over a month, is there a different maintainer then who should take this?
Mark