git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 0/4] Remove obsolete Cygwin support from git-gui

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Aug 5, 2023, 14:47 UTC
Message-ID
<07677f17-be9b-dc46-d204-6fe46d46ebc0@gmail.com>
In-Reply-To
<xmqq4jmsiyhw.fsf@gitster.g>
On 6/27/23 13:52, Junio C Hamano wrote:
Show 31 quoted lines
> Mark Levedahl <mlevedahl@gmail.com> writes:
>
>> === This is an update, incorporating responses to Junio's and Eric's
>> comments:
>>    -- clarified what the "upstream" git-gui branch is
>>    -- Removed some changes from patch 2 as requested by Junio, reducing
>>       changes in patch 3 and patch 4
>>         All code is fixed only after applying patch 4
>>         Differences in patch 3 and 4 are minimimized
>>     -- updated comments to clarify G4w dedicated code.
>>     -- updated all comments to (hopefully) clarify points of confusion
>> ===
>> ...
>> Mark Levedahl (4):
>>    git gui Makefile - remove Cygwin modifications
>>    git-gui - remove obsolete Cygwin specific code
>>    git-gui - use cygstart to browse on Cygwin
>>    git-gui - use mkshortcut on Cygwin
>>
>>   Makefile                  |  21 +------
>>   git-gui.sh                | 118 +++-----------------------------------
>>   lib/choose_repository.tcl |  27 +--------
>>   lib/shortcut.tcl          |  31 +++++-----
>>   4 files changed, 27 insertions(+), 170 deletions(-)
> OK, Dscho says v1 looks good, and I have no further comments.
>
> Pratyush, can I expect that you take further comments and usher
> these patches to your tree, and eventually tell me to pull from your
> repository?
>
> Thanks, all.
Junio,

Thank you and Dscho for the detailed reviews. But, there is no response from Pratyush in over a month, is there a different maintainer then who should take this?

Mark
Previous: Junio C HamanoNext: Pratyush Yadav
Message 24 of 27 in “Remove obsolete Cygwin support from git-gui”
  1. 0/4 Remove obsolete Cygwin support from git-guiMark Levedahl, Jun 24, 2023
  2. 1/4 git gui Makefile - remove Cygwin modiificationsMark Levedahl, Jun 24, 2023
  3. 2/4 git-gui - remove obsolete Cygwin specific codeMark Levedahl, Jun 24, 2023
  4. Eric SunshineJun 25, 2023
  5. Mark LevedahlJun 25, 2023
  6. 3/4 git-gui - use cygstart to browse on CygwinMark Levedahl, Jun 24, 2023
  7. 4/4 git-gui - use mkshortcut on CygwinMark Levedahl, Jun 24, 2023
  8. Junio C HamanoJun 24, 2023
  9. Junio C HamanoJun 24, 2023
  10. Mark LevedahlJun 25, 2023
  11. Mark LevedahlJun 25, 2023
  12. Mark LevedahlJun 25, 2023
  13. Junio C HamanoJun 25, 2023
  14. Mark LevedahlJun 25, 2023
  15. Junio C HamanoJun 26, 2023
  16. Mark LevedahlJun 26, 2023
  17. 0/4 Remove obsolete Cygwin support from git-guiMark Levedahl, Jun 26, 2023
  18. 1/4 git gui Makefile - remove Cygwin modificationsMark Levedahl, Jun 26, 2023
  19. 2/4 git-gui - remove obsolete Cygwin specific codeMark Levedahl, Jun 26, 2023
  20. 3/4 git-gui - use cygstart to browse on CygwinMark Levedahl, Jun 26, 2023
  21. 4/4 git-gui - use mkshortcut on CygwinMark Levedahl, Jun 26, 2023
  22. Johannes SchindelinJun 27, 2023
  23. Junio C HamanoJun 27, 2023
  24. Mark LevedahlAug 5, 2023
  25. Pratyush YadavAug 24, 2023
  26. Mark LevedahlAug 29, 2023
  27. Junio C HamanoAug 29, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.