git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4053: avoid race when killing background processes

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 11, 2023, 15:47 UTC
Message-ID
<xmqqsf8poa28.fsf@gitster.g>
In-Reply-To
<2d9e9b59-bf78-8470-0731-3cd7fe15a727@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 14 quoted lines
> On 10/08/2023 18:40, Junio C Hamano wrote:
>> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>> While I can see that "kill" in the when-finished handler may or may
>> not find the backgrounded process by the time it is run, and
>> ignoring its exit status (hence keeping test_when_finished happy)
>> would be a reasonable thing to do.  I can understand if this patch
>> is to fix a different symptom, namely, when-finished handler
>> sometimes fails and makes the test fail.
>> But I am not sure how this causes the test to "hang", 
>
>
> This is only a fix for the test failure that Peff saw when running
> with --stress.

Ah, OK. I obviously misread the proposed commit log message. And as a race-fix, this would be good.

Thanks.
Previous: Jeff King
Message 5 of 5 in “t4053: avoid race when killing background processes”
  1. t4053: avoid race when killing background processesPhillip Wood via GitGitGadget, Aug 10, 2023
  2. Junio C HamanoAug 10, 2023
  3. Phillip WoodAug 11, 2023
  4. Jeff KingAug 11, 2023
  5. Junio C HamanoAug 11, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.