Re: [PATCH] t4053: avoid race when killing background processes
- From
Jeff King <peff@peff.net>
- Date
- Aug 11, 2023, 14:44 UTC
- Message-ID
- <20230811144403.GA2303200@coredump.intra.peff.net>
- In-Reply-To
- <2d9e9b59-bf78-8470-0731-3cd7fe15a727@gmail.com>
On Fri, Aug 11, 2023 at 10:56:40AM +0100, Phillip Wood wrote:
Show 10 quoted lines
> This is only a fix for the test failure that Peff saw when running with > --stress. > > > which > > presumably is a symptom that somebody is trying to read from > > a pipe that nobody is making progress to write into? > > That or a process blocking when tying to open a fifo seems the mostly likely > cause but I can't see where that is happening. As you say this patch does > not obviously change anything that would be causing the test to hang.
Yeah, sorry if my initial report was unclear. It was while digging for the cause of the hang that I ran into the racy failures. This patch looks good for fixing the race. I'm still waiting to hit the hang again to get more data. But if it never happens again, then that is a success of sorts. :)
-Peff