Re: [PATCH 4/4] trace2: remove unneeded calls to generate 'def_param' set

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 6, 2024, 23:00 UTC
Message-ID: <xmqqsf13otii.fsf@gitster.g>
In-Reply-To: <f1c1847f-49fa-5573-55f4-7cca401df401@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

Show 9 quoted lines

>>> Reviewed-by: Josh Steadmon <steadmon@google.com>
>> Let's see what JeffH says about this.  I agree with you that making
>> some stuff redundant in [Patch 3/4] and fixing the redundancy in
>> this step does feel somewhat roundabout way of doing this.
>> Thanks.
>> 
>
> Sure we can merge them.  That's fine.  I can send a V4 or if you want
> to just squash them together that's fine.

Let's have a v4 describing the change for combined 3&4 in your words, with Josh's Reviewed-by: already added to the trailers.

Thanks, both of you.