git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] trace2: remove unneeded calls to generate 'def_param' set

From
JGJeff Hostetler via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 4, 2024, 15:40 UTC
Message-ID
<e8528715ebf97c12622c2e73f914ab4228a0927c.1709566808.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1679.git.1709566808.gitgitgadget@gmail.com>
From: Jeff Hostetler <jeffhostetler@github.com>

Now that "trace2_cmd_name()" implicitly calls "trace2_cmd_list_config()" and "trace2_cmd_list_env_vars()", we don't need to explicitly call them.

Signed-off-by: Jeff Hostetler <jeffhostetler@github.com>
---
 git.c | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/git.c b/git.c
index 7068a184b0a..a769d72ab8f 100644
--- a/git.c
+++ b/git.c
@@ -373,8 +373,6 @@ static int handle_alias(int *argcp, const char ***argv)
 			strvec_pushv(&child.args, (*argv) + 1);
 
 			trace2_cmd_alias(alias_command, child.args.v);
-			trace2_cmd_list_config();
-			trace2_cmd_list_env_vars();
 			trace2_cmd_name("_run_shell_alias_");
 
 			ret = run_command(&child);
@@ -411,8 +409,6 @@ static int handle_alias(int *argcp, const char ***argv)
 		COPY_ARRAY(new_argv + count, *argv + 1, *argcp);
 
 		trace2_cmd_alias(alias_command, new_argv);
-		trace2_cmd_list_config();
-		trace2_cmd_list_env_vars();
 
 		*argv = new_argv;
 		*argcp += count - 1;
@@ -462,8 +458,6 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
 
 	trace_argv_printf(argv, "trace: built-in: git");
 	trace2_cmd_name(p->cmd);
-	trace2_cmd_list_config();
-	trace2_cmd_list_env_vars();
 
 	validate_cache_entries(the_repository->index);
 	status = p->fn(argc, argv, prefix);
-- 
gitgitgadget
Previous: Jeff Hostetler via GitGitGadgetNext: Josh Steadmon
Message 5 of 13 in “trace2: move 'def_param' events into 'cmd_name' and 'cmd_alias'”
  1. 0/4 trace2: move 'def_param' events into 'cmd_name' and 'cmd_alias'Jeff Hostetler via GitGitGadget, Mar 4, 2024
  2. 1/4 t0211: demonstrate missing 'def_param' events for certain commandsJeff Hostetler via GitGitGadget, Mar 4, 2024
  3. 2/4 trace2: avoid emitting 'def_param' set more than onceJeff Hostetler via GitGitGadget, Mar 4, 2024
  4. 3/4 trace2: emit 'def_param' set with 'cmd_name' eventJeff Hostetler via GitGitGadget, Mar 4, 2024
  5. 4/4 trace2: remove unneeded calls to generate 'def_param' setJeff Hostetler via GitGitGadget, Mar 4, 2024
  6. Josh SteadmonMar 6, 2024
  7. Junio C HamanoMar 6, 2024
  8. Jeff HostetlerMar 6, 2024
  9. Junio C HamanoMar 6, 2024
  10. 0/3 trace2: move generation of 'def_param' events into code for 'cmd_name'Jeff Hostetler via GitGitGadget, Mar 7, 2024
  11. 2/3 trace2: avoid emitting 'def_param' set more than onceJeff Hostetler via GitGitGadget, Mar 7, 2024
  12. 1/3 t0211: demonstrate missing 'def_param' events for certain commandsJeff Hostetler via GitGitGadget, Mar 7, 2024
  13. 3/3 trace2: emit 'def_param' set with 'cmd_name' eventJeff Hostetler via GitGitGadget, Mar 7, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.