Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2024, 18:29 UTC
Message-ID: <xmqqseze1seh.fsf@gitster.g>
In-Reply-To: <pull.1711.git.git.1713642690371.gitgitgadget@gmail.com>

"Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 18 quoted lines

> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
>
>  Documentation/RelNotes/2.45.0.txt | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt
> index 0570dcd8773..38458664407 100644
> --- a/Documentation/RelNotes/2.45.0.txt
> +++ b/Documentation/RelNotes/2.45.0.txt
> @@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc.
>  
>   * The way placeholders are to be marked-up in documentation have been
>     specified; use "_<placeholder>_" to typeset the word inside a pair
> -   of <angle-brakets> emphasized.
> +   of <angle-brackets> emphasized.

Thanks.

Show 9 quoted lines

> @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
>     clean.requireForce has been simplified, together with the
>     documentation.
>  
> - * The code to iterate over refs with the reftable backend has seen
> -   some optimization.
> -
>   * Uses of xwrite() helper have been audited and updated for better
>     error checking and simpler code.

Interesting. It is likely that we had two topics that did things that summarised down to the same description. They are

 448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14)
 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)

I do not know which is better between removing the second entry (which is what this patch is doing, as the entries are in chronological order of the topics' graduation to 'master'), or amending it to say "has seen some more optimization".