git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 22, 2024, 05:51 UTC
Message-ID
<ZiX616G0PPp1jICn@tanuki>
In-Reply-To
<xmqqseze1seh.fsf@gitster.g>
On Sun, Apr 21, 2024 at 11:29:10AM -0700, Junio C Hamano wrote:
Show 25 quoted lines
> "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > From: Orgad Shaneh <orgads@gmail.com>
> >
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> > @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
> >     clean.requireForce has been simplified, together with the
> >     documentation.
> >  
> > - * The code to iterate over refs with the reftable backend has seen
> > -   some optimization.
> > -
> >   * Uses of xwrite() helper have been audited and updated for better
> >     error checking and simpler code.
> 
> Interesting.  It is likely that we had two topics that did things
> that summarised down to the same description.  They are 
> 
>  448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14)
>  9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)
> 
> I do not know which is better between removing the second entry
> (which is what this patch is doing, as the entries are in
> chronological order of the topics' graduation to 'master'), or
> amending it to say "has seen some more optimization".

Squashing these into a single entry should be fine in my opinion. The split was artificial anyway to make the review process easier.

Patrick
Previous: Junio C Hamano
Message 3 of 3 in “docs: remove duplicate entry and fix typo in 2.45 changelog”
  1. docs: remove duplicate entry and fix typo in 2.45 changelogOrgad Shaneh via GitGitGadget, Apr 20, 2024
  2. Junio C HamanoApr 21, 2024
  3. Patrick SteinhardtApr 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.