git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] diff: report copies and renames as changes in run_diff_cmd()

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 9, 2024, 16:59 UTC
Message-ID
<xmqqseu8sqzq.fsf@gitster.g>
In-Reply-To
<b4ce7873-3dfa-443c-847c-64200fd065cc@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 10 quoted lines
>> which is inconsistent with the quicker one.  Fix it.  Even if we ignore
>> the file contents (because it's empty or contains only ignored lines),
>> there's still the meta data change of adding or changing a filename, so
>> we need to report it in the exit code.
>> d7b97b7185 (diff: let external diffs report that changes are
>> uninteresting, 2024-06-09) set diff_from_contents if external diff
>> programs are allowed.  This is the default e.g. for git diff, and so
>> that change exposed the inconsistency much more widely.
>
> Thanks for fixing this - both patches looks good to me.
Yup, thanks, both.
Previous: Phillip Wood
Message 4 of 4 in “diff: report copies and renames as changes in run_diff_cmd()”
  1. 1/2 diff: report copies and renames as changes in run_diff_cmd()René Scharfe, Sep 8, 2024
  2. 2/2 diff: report dirty submodules as changes in builtin_diff()René Scharfe, Sep 8, 2024
  3. Phillip WoodSep 9, 2024
  4. Junio C HamanoSep 9, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.