From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Sep 2024 16:59:05 GMT
Subject: Re: [PATCH 1/2] diff: report copies and renames as changes in run_diff_cmd()
Message-ID: <xmqqseu8sqzq.fsf@gitster.g>
In-Reply-To: <b4ce7873-3dfa-443c-847c-64200fd065cc@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

>> which is inconsistent with the quicker one.  Fix it.  Even if we ignore
>> the file contents (because it's empty or contains only ignored lines),
>> there's still the meta data change of adding or changing a filename, so
>> we need to report it in the exit code.
>> d7b97b7185 (diff: let external diffs report that changes are
>> uninteresting, 2024-06-09) set diff_from_contents if external diff
>> programs are allowed.  This is the default e.g. for git diff, and so
>> that change exposed the inconsistency much more widely.
>
> Thanks for fixing this - both patches looks good to me.

Yup, thanks, both.