Re: [PATCH v2] strvec: `strvec_splice()` to a statically initialized vector

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2024, 10:15 UTC
Message-ID: <xmqqser33ga6.fsf@gitster.g>
In-Reply-To: <4e60eedc-e4d9-423c-b2e7-f1c65bccc254@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 16 quoted lines

>> @@ -66,6 +66,7 @@ void strvec_splice(struct strvec *array, size_t idx, size_t len,
>>                         array->v = NULL;
>>                 ALLOC_GROW(array->v, array->nr + (replacement_len - len) + 1,
>>                            array->alloc);
>> +               array->v[array->nr + 1] = NULL;
>
> I mean:
>
> +               array->v[array->nr + (replacement_len - len) + 1] = NULL;
>
>
>>         }
>>         for (size_t i = 0; i < len; i++)
>>                 free((char *)array->v[idx + i]);
>> 
>> Sorry.  I'll re-roll later today.

No need to say "sorry". Thanks for quickly reacting and starting to work on it.