git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t1016: make sure to use specified GPG

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 10, 2025, 21:14 UTC
Message-ID
<xmqqsefq7947.fsf@gitster.g>

c348192a (t1016: clean up style, 2024-10-22) fixed a coding style violation that has an extra space between redirection operator ">" and the redirection target, but at the same time, replaced the use of "git config" to set a configuration variable to be used by the remainder of tests with "test_config". The pattern employed here is that the first set-up test prepares the environment to be used by subsequent tests, which then use the settings left by this set-up test to perform their tasks. Using test_config in the first set-up test means the config setting made by the set-up test is reverted at the end of the first set-up test, which totally misses the point.

Go back to use "git config" to fix this.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * The commit in question was from October last year, and I didn't
   notice it until I looked at how the test script evolved.  It is a
   bit embarrassing that we didn't catch it during review.
 t/t1016-compatObjectFormat.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh
index 8341a2fe83..cb6d308f1d 100755
--- a/t/t1016-compatObjectFormat.sh
+++ b/t/t1016-compatObjectFormat.sh
@@ -116,7 +116,7 @@ do
 		git config core.repositoryformatversion 1 &&
 		git config extensions.objectformat $hash &&
 		git config extensions.compatobjectformat $(compat_hash $hash) &&
-		test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
+		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
 		echo "Hello World!" >hello &&
 		eval hello_${hash}_oid=$(git hash-object hello) &&
 		git update-index --add hello &&
-- 
2.51.0-616-gc7d8d4fd8b
Next: Todd Zullinger
Message 1 of 8 in “t1016: make sure to use specified GPG”
  1. t1016: make sure to use specified GPGJunio C Hamano, Oct 10, 2025
  2. Todd ZullingerOct 12, 2025
  3. Junio C HamanoOct 12, 2025
  4. Todd ZullingerOct 12, 2025
  5. Junio C HamanoOct 23, 2025
  6. Todd ZullingerOct 24, 2025
  7. Andrew KreimerOct 12, 2025
  8. Junio C HamanoOct 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.