Re: [PATCH] t1016: make sure to use specified GPG
- From
Todd Zullinger <tmz@pobox.com>
- Date
- Oct 24, 2025, 01:52 UTC
- Message-ID
- <aPrb3QGTNE7IBClk@teonanacatl.net>
- In-Reply-To
- <xmqq3479tk78.fsf@gitster.g>
Junio C Hamano wrote:
Show 19 quoted lines
> Todd Zullinger <tmz@pobox.com> writes: > >> Junio C Hamano wrote: >>> Todd Zullinger <tmz@pobox.com> writes: >>> >>>> Interesting. And well-spotted. >>>> >>>> This _does_ seem to resolve the failures in our CI and in >>>> the Fedora build system. I was able to run a few test >>>> builds. With this fix, the tests were successful where they >>>> were not without it. >>> ... >>> FWIW, GitHub CI jobs are failing t1016 at the tip of 'seen' (which >>> has this change), but only some and not all the jobs, which may >>> indicate there are timeing-dependent flakes involved. I didn't dig >>> further, though. > > Let's merge this fix down, even though it does not seem to have > any effect improving the situation of flaky tests here.
Sounds good, thanks. It's the right thing to do, even if it didn't clear up the issues which led to you noticing.
-- Todd