git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 4/4] rebase: support --trailer

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 20, 2026, 20:49 UTC
Message-ID
<xmqqsec0xb50.fsf@gitster.g>
In-Reply-To
<cb5a792f-c763-4fbf-bfcc-52f66c895c9e@app.fastmail.com>
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
Show 16 quoted lines
> On Wed, Nov 5, 2025, at 15:29, Li Chen wrote:
>> From: Li Chen <chenl311@chinatelecom.cn>
> ...
> Same problem as I commented on in https://lore.kernel.org/git/cbe93380-e145-4ebd-a213-928b8c3ba085@app.fastmail.com/
>
> The `See also INCOMPATIBLE OPTIONS below.` is not indented to the same
> level as `--signoff`, where it belongs.
>
>> +--trailer=<trailer>::
>> +       Append the given trailer line(s) to every rebased commit
>> +       message, processed via linkgit:git-interpret-trailers[1].
>> +       When this option is present *rebase automatically implies*
>> +       `--force-rebase` so that fast‑forwarded commits are also
>> +       rewritten.
>> +
>>[snip]

After this and [*] the discussion stopped and the topic has been dormant since then for full two months. I'd drop the topic from 'seen' soonish but that does not mean an improved version of this patch is unwelcome.

Thanks.
[Reference]
 * https://lore.kernel.org/git/19a8fe42354.3909481a3912041.7970296104893780556@linux.beauty/
Previous: Kristoffer HaugsbakkNext: Junio C Hamano
Message 20 of 24 in “rebase: support --trailer”
  1. 0/4 rebase: support --trailerLi Chen, Nov 5, 2025
  2. 1/4 interpret-trailers: factor out buffer-based processing to process_trailers()Li Chen, Nov 5, 2025
  3. Junio C HamanoNov 5, 2025
  4. Phillip WoodNov 10, 2025
  5. Li ChenNov 10, 2025
  6. Junio C HamanoNov 10, 2025
  7. Li ChenNov 10, 2025
  8. 2/4 trailer: move process_trailers to trailer.hLi Chen, Nov 5, 2025
  9. Junio C HamanoNov 5, 2025
  10. 3/4 trailer: append trailers in-process and drop the fork to `interpret-trailers`Li Chen, Nov 5, 2025
  11. Junio C HamanoNov 5, 2025
  12. Li ChenNov 10, 2025
  13. Phillip WoodNov 10, 2025
  14. Li ChenNov 10, 2025
  15. Li ChenFeb 24, 2026
  16. Phillip WoodNov 11, 2025
  17. 4/4 rebase: support --trailerLi Chen, Nov 5, 2025
  18. Phillip WoodNov 12, 2025
  19. Kristoffer HaugsbakkNov 24, 2025
  20. Junio C HamanoJan 20, 2026
  21. Junio C HamanoNov 5, 2025
  22. Li ChenNov 10, 2025
  23. Phillip WoodNov 12, 2025
  24. Li ChenNov 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.