git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/4] rebase: support --trailer

From
Li Chen <me@linux.beauty>
Date
Nov 17, 2025, 03:38 UTC
Message-ID
<19a8fe42354.3909481a3912041.7970296104893780556@linux.beauty>
In-Reply-To
<bfa6c82d-f0b9-4248-88be-8a95bc22ebc1@gmail.com>
Hi Phillip,
Sorry for my late reply.
 ---- On Wed, 12 Nov 2025 22:50:27 +0800  Phillip Wood <phillip.wood123@gmail.com> wrote --- 
 > Hi Li
 > 
 > On 05/11/2025 14:29, Li Chen wrote:
 > > From: Li Chen <chenl311@chinatelecom.cn>
 > > 
 > > This series routes all trailer insertion through an in-process path, removing
 > > the fork/exec to builtin/interpret-trailers and tempfile juggling. The first
 > > three commits centralize logic to reduce overhead and simplify error handling.
 > > The final commit adds git rebase --trailer, currently supported with the merge
 > > backend only (rejecting apply-only scenarios and validating input early).
 > 
 > I've left quite a few comments but overall this is looking much better 
 > now, it needs a bit of cleaning up but I didn't spot any major issues.
 > 
 > Thanks for working on it
 
Thanks for your kind reviews! I will address them in the next version.
Regards,
Li​
Previous: Phillip Wood
Message 24 of 24 in “rebase: support --trailer”
  1. 0/4 rebase: support --trailerLi Chen, Nov 5, 2025
  2. 1/4 interpret-trailers: factor out buffer-based processing to process_trailers()Li Chen, Nov 5, 2025
  3. Junio C HamanoNov 5, 2025
  4. Phillip WoodNov 10, 2025
  5. Li ChenNov 10, 2025
  6. Junio C HamanoNov 10, 2025
  7. Li ChenNov 10, 2025
  8. 2/4 trailer: move process_trailers to trailer.hLi Chen, Nov 5, 2025
  9. Junio C HamanoNov 5, 2025
  10. 3/4 trailer: append trailers in-process and drop the fork to `interpret-trailers`Li Chen, Nov 5, 2025
  11. Junio C HamanoNov 5, 2025
  12. Li ChenNov 10, 2025
  13. Phillip WoodNov 10, 2025
  14. Li ChenNov 10, 2025
  15. Li ChenFeb 24, 2026
  16. Phillip WoodNov 11, 2025
  17. 4/4 rebase: support --trailerLi Chen, Nov 5, 2025
  18. Phillip WoodNov 12, 2025
  19. Kristoffer HaugsbakkNov 24, 2025
  20. Junio C HamanoJan 20, 2026
  21. Junio C HamanoNov 5, 2025
  22. Li ChenNov 10, 2025
  23. Phillip WoodNov 12, 2025
  24. Li ChenNov 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.