Re: [PATCH v4 0/3] compat/posix.h: enable UNUSED warning messages for Clang

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2026, 16:39 UTC
Message-ID: <xmqqse6qe6oo.fsf@gitster.g>
In-Reply-To: <20260613122711.38662-1-dominik.loidolt@univie.ac.at>

Dominik Loidolt <dominik.loidolt@univie.ac.at> writes:

Show 17 quoted lines

> This series enables the intended UNUSED warning message with Clang by
> adding a dedicated Clang version check. It also cleans up the nearby
> GIT_GNUC_PREREQ() and UNUSED macros.
>
> Changes since v3:
> - split style-only cleanups into their own patch
> - fix the UNUSED preprocessor indentation style
> - simplify the GIT_GNUC_PREREQ() comparison commit message
> - keep the Clang-specific note in the patch that adds GIT_CLANG_PREREQ()
>
> Thanks,
>  Dominik
>
> Dominik Loidolt (3):
>   compat/posix.h: enable UNUSED warning messages for Clang
>   compat/posix.h: clean up GIT_GNUC_PREREQ() and UNUSED
>   compat/posix.h: simplify GIT_GNUC_PREREQ() comparison

Looking good and all the points Patrick raised during the review of the previous round seem to have been addressed nicely.

Will replace.  Shall we mark it for 'next' now?

Thanks.