Re: [PATCH v2 0/6] [doc] Add new page on merge conflicts

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 9, 2026, 15:41 UTC
Message-ID: <xmqqse2evq2k.fsf@gitster.g>
In-Reply-To: <pull.2237.v2.git.1791547213.gitgitgadget@gmail.com>

"Julia Evans via GitGitGadget" <gitgitgadget@gmail.com> writes:

>  * [x] list reviewers in Reviewed-by

We may have a bit of misunderstanding in the process regarding this.

. `Reviewed-by:`, unlike the other trailers, can only be offered by the
  reviewers themselves when they are completely satisfied with the
  patch after a detailed analysis.

is how SubmittingPatches describes it.

ReviewingGuidelines.adoc tells reviewers

  If you are happy with the state of the patch series, explicitly
  indicate your approval (typically with a reply to the latest
  version's cover letter). Optionally, you can let the author know
  that they can add a "Reviewed-by: <you>" trailer if they resubmit
  the reviewed patch verbatim in a later iteration of the series.

For example, you added Ben and Patrick to the trailer of patch #1.

Show 14 quoted lines

> Range-diff vs v1:
>
>  1:  ad4853dc36 ! 1:  ab0344f947 [doc] Add new gitmergeconflicts man page
>      @@ Metadata
>       Author: Julia Evans <julia@jvns.ca>
>       
>        ## Commit message ##
>      -    [doc] Add new gitmergeconflicts man page
>      +    doc: add new gitmergeconflicts man page
> ...
>           Co-Authored-By: Marie Claire LeBlanc Flanagan <hello@marieflanagan.com>
>      +    Reviewed-by: D. Ben Knoble <ben.knoble+github@gmail.com>
>      +    Reviewed-by: Patrick Steinhardt <ps@pks.im>
>           Signed-off-by: Julia Evans <julia@jvns.ca>

Going back to the review thread of the previous round of this patch, https://lore.kernel.org/git/ar3sGzEknG2_Un_E@pks.im/

2026-09-24 14:44 ` [PATCH 1/7] [doc] Add new gitmergeconflicts man page Julia Evans via GitGitGadget 2026-09-24 20:36 ` Junio C Hamano 2026-09-24 22:04 ` Junio C Hamano 2026-09-30 13:19 ` Patrick Steinhardt 2026-09-30 19:53 ` Julia Evans 2026-09-30 20:37 ` Junio C Hamano 2026-10-01 5:14 ` Patrick Steinhardt [this message] 2026-10-01 12:10 ` Julia Evans 2026-10-02 17:58 ` Junio C Hamano 2026-10-05 16:54 ` Julia Evans 2026-10-05 17:22 ` Junio C Hamano 2026-10-05 19:11 ` Julia Evans

There are many messages that reply to the cover letter of the same iteration by Ben that gave a lot of good input, and I know Patrick also helped during the discussion to improve the document. I do not think neither of them said anything about reviewed-by.

We do want to credit the reviewers of previous rounds for their input that contributed to improvements in the latest round. But the way to do so is by mentioning them on "Helped-by:" you add.

Thanks.