git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] fsmonitor: check the untracked cache after a trivial response

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 9, 2026, 21:34 UTC
Message-ID
<xmqqse19wuwy.fsf@gitster.g>
In-Reply-To
<xmqq8q31yb5s.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
>> Thanks for these improvements. The v2 patch LGTM.
>>
>>>      * rebased against ToT
>>
>> Generally, you shouldn't do this as the maintainer will apply
>> your patch in the same spot and handle most merge conflicts
>> via rerere, but rebasing interrupts that. The main exception
>> is when you rebase onto a specific topic or with regards to a
>> large refactor that merged recently.
>
> Good suggestion.  Worse yet, the topic is already in 'next' so a
> wholesale replacement is not very welcome.

Well, I ended up reverting the merge to 'next', and queued this iteration (applied on exactly the same base as v1 was applied in my tree---the patch cleanly applied as if there were no rebase). I'll mark the topic again ready for 'next' after waiting for a few days to see if there are any more feedback.

Thanks, all.
Previous: Junio C Hamano
Message 8 of 8 in “fsmonitor: check the untracked cache after a trivial response”
  1. fsmonitor: check the untracked cache after a trivial responseIlia via GitGitGadget, Oct 4, 2026
  2. Derrick StoleeNov 5, 2026
  3. Junio C HamanoNov 5, 2026
  4. Ilia KNov 9, 2026
  5. fsmonitor: check the untracked cache after a trivial responseIlia via GitGitGadget, Nov 9, 2026
  6. Derrick StoleeNov 9, 2026
  7. Junio C HamanoNov 9, 2026
  8. Junio C HamanoNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.