Re: [PATCH v2] fsmonitor: check the untracked cache after a trivial response
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 9, 2026, 20:58 UTC
- Message-ID
- <xmqq8q31yb5s.fsf@gitster.g>
- In-Reply-To
- <fefa2680-695c-41db-9975-7e972590b969@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 15 quoted lines
> On 11/9/2026 2:14 PM, Ilia via GitGitGadget wrote: >> Changes since v1: >> >> * the whole untracked cache is dropped if !worktree >> * removed the comments as per nits > > Thanks for these improvements. The v2 patch LGTM. > >> * rebased against ToT > > Generally, you shouldn't do this as the maintainer will apply > your patch in the same spot and handle most merge conflicts > via rerere, but rebasing interrupts that. The main exception > is when you rebase onto a specific topic or with regards to a > large refactor that merged recently.
Good suggestion. Worse yet, the topic is already in 'next' so a wholesale replacement is not very welcome.