Re: [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2026, 16:13 UTC
- Message-ID
- <xmqqse18u0jw.fsf@gitster.g>
- In-Reply-To
- <avLCDTHuScp4iLyj@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> All I'm pointing out is that there are cases where we could be as > defensive as everywhere else if we started passing down the options to > calling contexts that don't have it yet.
OK, that does make sense, but I suspect the current helper functions that do not get unpack_opt do not because they do not have a reason to access anything in it. We could throw "struct repository *" into that struct and use that one (ignoring the one in the istates).
I however think that would be a separate clean-up.
Thanks.