git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] unpack-trees: consistently use "struct index_state *istate"

From
Derrick Stolee <stolee@gmail.com>
Date
Nov 9, 2026, 13:46 UTC
Message-ID
<b3004724-3ed6-4b41-8b3f-eaa19a09394d@gmail.com>
In-Reply-To
<xmqqpkwhbfa1.fsf@gitster.g>
On 11/6/2026 8:29 PM, Junio C Hamano wrote:
Show 7 quoted lines
> There are some functions that call it index.  Make them consistent.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  * This change is not necessary for functioning of anything, but
>    while writing the previous patch, the inconsistency was
>    irritating enough.

I agree that making this consistent will help a lot when mutating the code in the future. Doing this cleanup next to the_repository cleanup makes sense.

Thanks, -Stolee

Previous: Junio C HamanoNext: Patrick Steinhardt
Message 3 of 15 in “unpack-trees: lose USE_THE_REPOSITORY”
  1. 1/2 unpack-trees: lose USE_THE_REPOSITORYJunio C Hamano, Nov 7, 2026
  2. 2/2 unpack-trees: consistently use "struct index_state *istate"Junio C Hamano, Nov 7, 2026
  3. Derrick StoleeNov 9, 2026
  4. Patrick SteinhardtNov 9, 2026
  5. Junio C HamanoNov 9, 2026
  6. Patrick SteinhardtNov 10, 2026
  7. Junio C HamanoNov 10, 2026
  8. Patrick SteinhardtNov 10, 2026
  9. Derrick StoleeNov 9, 2026
  10. 0/2 unpack-trees.c w/o the_repositoryJunio C Hamano, Nov 9, 2026
  11. 1/2 unpack-trees: lose USE_THE_REPOSITORYJunio C Hamano, Nov 9, 2026
  12. 2/2 unpack-trees: consistently use "struct index_state *istate"Junio C Hamano, Nov 9, 2026
  13. Derrick StoleeNov 10, 2026
  14. Junio C HamanoNov 10, 2026
  15. Patrick SteinhardtNov 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.