git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] enums: remove trailing ',' after last item in enum

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 9, 2014, 14:59 UTC
Message-ID
<xmqqr41u7f37.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1404325445-17914-1-git-send-email-sahlberg@google.com>
Ronnie Sahlberg <sahlberg@google.com> writes:
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> ---
Looks good; thanks.
Show 44 quoted lines
>  builtin/clean.c | 2 +-
>  builtin/tag.c   | 2 +-
>  pretty.c        | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 9a91515..27701d2 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -48,7 +48,7 @@ enum color_clean {
>  	CLEAN_COLOR_PROMPT = 2,
>  	CLEAN_COLOR_HEADER = 3,
>  	CLEAN_COLOR_HELP = 4,
> -	CLEAN_COLOR_ERROR = 5,
> +	CLEAN_COLOR_ERROR = 5
>  };
>  
>  #define MENU_OPTS_SINGLETON		01
> diff --git a/builtin/tag.c b/builtin/tag.c
> index c6e8a71..ef76556 100644
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -83,7 +83,7 @@ static int in_commit_list(const struct commit_list *want, struct commit *c)
>  enum contains_result {
>  	CONTAINS_UNKNOWN = -1,
>  	CONTAINS_NO = 0,
> -	CONTAINS_YES = 1,
> +	CONTAINS_YES = 1
>  };
>  
>  /*
> diff --git a/pretty.c b/pretty.c
> index 4f51287..924bc61 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -274,7 +274,7 @@ static void add_rfc822_quoted(struct strbuf *out, const char *s, int len)
>  
>  enum rfc2047_type {
>  	RFC2047_SUBJECT,
> -	RFC2047_ADDRESS,
> +	RFC2047_ADDRESS
>  };
>  
>  static int is_rfc2047_special(char ch, enum rfc2047_type type)
Previous: Ronnie Sahlberg
Message 4 of 4 in “enums: remove trailing ',' after last item in enum”
  1. enums: remove trailing ',' after last item in enumRonnie Sahlberg, Jul 2, 2014
  2. Jonathan NiederJul 2, 2014
  3. Ronnie SahlbergJul 2, 2014
  4. Junio C HamanoJul 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.